Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: unit testing #16

Merged
merged 6 commits into from
Feb 3, 2025
Merged

chore: unit testing #16

merged 6 commits into from
Feb 3, 2025

Conversation

carenthomas
Copy link
Collaborator

still debugging some issues so this won't pass yet

@carenthomas carenthomas marked this pull request as draft January 25, 2025 00:18
cpacker
cpacker reviewed Jan 25, 2025
View reviewed changes
tests/custom.test.ts Outdated Show resolved Hide resolved
cpacker
cpacker reviewed Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great starting point. I think we want to add some stuff for data sources since that's quite visible in the ADE, so we want to make sure the SDK is working for it.

carenthomas
carenthomas commented Jan 25, 2025
View reviewed changes
tests/custom.test.ts Outdated Show resolved Hide resolved
@carenthomas carenthomas marked this pull request as ready for review February 3, 2025 22:35
@carenthomas carenthomas merged commit 42677dc into main Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpacker cpacker cpacker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carenthomas @cpacker